Unneeded items list not working right #285
Comments
|
It's possible that the tool might miss some unneeded items. My guess here is that your Tribble Kirk is not immortalized? That's one of the conditions it looks for currently, though this might be something we can fix. Also, to be clear, are you saying that the tool also identifies items as unneeded even when you know you need them? That's definitely not the intended behavior and we'll have to look into that one with more urgency. |
|
I have an example of it identifying items as unneeded when they are. I have two items: 2* Riker's Uniform and 2* Yar's Phaser. It reports those as "used to equip specific crew you already equipped" which is probably true. However, both of those items are used as components for equipment I'm in the process of building for Armus. |
|
I have noticed this bug for months and ignored the unneeded items tab because of it. |
|
I can confirm that equipment might be listed as unneeded when they're actually needed subcomponents of a higher-level item, as @MagForceSeven pointed out. @wathou6 The algorithm as written doesn't consider all items, so there's a good chance it will miss out on some equipment that is no longer needed. I think this was generally acceptable because it was better to list too few items than too many. But given the glaring oversight of needed subcomponents, we'll probably have to find a new approach for this tool and we might as well make it more comprehensive in the process. Thanks for all the feedback. They're much appreciated! |
Adds another filter to the fodder check that assumes an item is needed if a higher quality item of the same name is needed. For example, 3* Kira's Pistol (which is unneeded on its own for any crew on my roster) will no longer be listed because it's similar in name to 4* Kira's Pistol (which is needed on my roster by an unequipped Decoy Kira). This will lead to some false positives (e.g. some 2* items are not actually building blocks of their equivalent 3* builds), but that's okay because it's better to be too conservative in recommendations than the alternative. Plus, the false positives will resolve themselves when the relevant crew become fully equipped. Unfortunately, the tool still cannot account for partial builds by different names, e.g. 3* Tuvix's Uniform needs 2* Starfleet Security Uniform (VOY), in which case the latter might still be listed as fodder even if Tuvix is unequipped. This is also the case first raised in #285 about Yar's Phaser being a building block of Armus' Skin. To reduce the chances of this, lower quality equipment (i.e. 0* and 1*) remain ignored by the final tier of recommendations (Other Equipment). The new disclaimer is hopefully enough to warn users of this possibility. If DataCore's items.json template gets updated with an incremental recipe tree, the `needsHigherQuality` function can be replaced with one that properly checks higher-level recipes for needed building blocks. Made small changes to some variable names and the disclaimer for clarity.
The un-needed items list appears to be broken. It lists un-needed ship schematics and potentially needed items, but no longer lists items you can safely discard. For instance, I have a Kirk's tribble tray in my inventory, but have a FF Tribble Kirk, so this should be extraneous and should be displayed in the discardable area.
The text was updated successfully, but these errors were encountered: