Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix substring crew matching in offers command #25

Open
ineffyble opened this issue Apr 2, 2021 · 0 comments
Open

Fix substring crew matching in offers command #25

ineffyble opened this issue Apr 2, 2021 · 0 comments

Comments

@ineffyble
Copy link
Member

The way we look for crew in offer text means that sometime we catch extra crew, if the crew on offer has a name that is a superstring of another crew.

Since the crew names are surrounded by HTML tags we can use this as a way to prevent this false matching.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ineffyble