-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move JDC initialization from main
to lib
#992
Comments
whatever function will end up initializing the role should take async streams of messages not addresses |
It was just a generic comment about make it more modular. Instead of open the socket on initialization, passing a stream of messages so we decouple actual role logic from tansport layer and encryption layer. This is useful for example if I want to initialize inside my application, and somewhere else in the application I already received and decrypted the messages. As I said above is a generic comment about this issue. Not sure if is suited for your PR or not. |
Done at #993 |
I am trying to write some tests running the whole flow, and noticed that JDC initialization is happening inside
main.rs
rather thanlib.rs
which makes it not very modular. I propose to move the initialization tolib
so it could be exported and used in different context, like testingThe text was updated successfully, but these errors were encountered: