Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC: WPBakery Compatibility #2585

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

JarrydLong
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Implements compatibility support for the WP Bakery Page Builder

How to test the changes in this Pull Request:

  1. Install WP Bakery
  2. Add a 'Text' field to the page
  3. Hit the settings button and scroll to the bottom.
  4. Enter in level ID's in the Paid Memberships Pro field
  5. The content will show/hide accordingly.

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

@andrewlimaza andrewlimaza changed the base branch from dev to v3.0 November 21, 2023 12:47
@dparker1005 dparker1005 added this to the 3.0 milestone Dec 6, 2023
@kimcoleman
Copy link
Member

@JarrydLong did some adjusting here - I am up in the air on if this is complete enough to merge in. Its strange how WP Bakery works that you have to basically rewrite their "shortcodes" / component like this. Makes me worry if a theme is doing this, it wouldn't work for the membership site.

But if people are asking for this, it is working now.

I adjusted some things here and also added a bail if in the context of the live editor so admins can build with this in the editing experience without content getting restricted. Give me a thumbs up or down on if you think we should hold this back to 3.1 or go for it now.

@dparker1005 dparker1005 modified the milestones: 3.0, 3.1 Dec 7, 2023
@JarrydLong
Copy link
Contributor Author

I think it works well for an MVP but maybe leave it for 3.1. Extending it to support other fields is quite easy which we can do (doesn't even need to be in a cycle) and have everything align with the other page builder integrations

@dparker1005 dparker1005 changed the base branch from v3.0 to dev April 11, 2024 16:13
@dparker1005 dparker1005 changed the base branch from dev to v3.1 June 14, 2024 15:53
@dparker1005 dparker1005 changed the base branch from v3.1 to dev July 17, 2024 16:29
@dparker1005 dparker1005 modified the milestones: 3.1, Backlog Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants