Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a API to track custom statements in a play function #17816

Open
wKich opened this issue Mar 29, 2022 · 2 comments
Open

Provide a API to track custom statements in a play function #17816

wKich opened this issue Mar 29, 2022 · 2 comments

Comments

@wKich
Copy link
Member

wKich commented Mar 29, 2022

Is your feature request related to a problem? Please describe
Hi. Frontside team here. We created a storybook addon for our interactors to track interactions in storybook inspector thefrontside/interactors#164. But the problem is that we use internal track method of storybook instrumenter to show interaction statements. That track method accepts method name, arguments and function. And because our interaction statement is created in runtime and sometime is pretty complicated we can't wrap our API in storybook instumenter, but we are able to provide the code representation call of interaction statement.

Describe the solution you'd like
Expose a public track function that accepts a statement string and function

Describe alternatives you've considered
Hm... Don't have, but we can discuss them

Are you able to assist to bring the feature to reality?
I can help with implementation if it's not required a lot of work

Additional context
Here is how current implementation looks like in storybook inspector
image

@cowboyd
Copy link

cowboyd commented Mar 29, 2022

@wKich Just noticed that we should probably not show default filter values that are not explicitly set.

@cowboyd
Copy link

cowboyd commented Mar 29, 2022

related: #16667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants