Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor w3up-client to pass Space via agent.delegate method #133

Open
fforbeck opened this issue Sep 20, 2024 · 1 comment
Open

Refactor w3up-client to pass Space via agent.delegate method #133

fforbeck opened this issue Sep 20, 2024 · 1 comment

Comments

@fforbeck
Copy link
Member

fforbeck commented Sep 20, 2024

Allow a space that isn't the current space to be passed to agent.delegate method.

This would allow us to get rid of the currentSpace concept more easily because right now the delegate assumes we are operating with the currentSpace so we often need to set it before calling the delegation method.

More info: storacha/w3up#1551 (comment)

Once that is implemented, we can refactor the client.shareSpace (code) method to remove the Space reset logic because we will provide the space DID as part of the delegate call.

@fforbeck
Copy link
Member Author

cc: @alanshaw

@fforbeck fforbeck changed the title Refactor w3up-client to pass Space via agent.delegate call Refactor w3up-client to pass Space via agent.delegate method Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant