Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mosaic] deprecation notice from jotai #259

Open
robbieaverill opened this issue Jul 3, 2024 · 1 comment
Open

[Mosaic] deprecation notice from jotai #259

robbieaverill opened this issue Jul 3, 2024 · 1 comment

Comments

@robbieaverill
Copy link

robbieaverill commented Jul 3, 2024

Context

The browser console is full of deprecation notices when using json-schema-viewer. I would love to help upgrade this dependency, however it seems like Mosaic is not an open source library.

Current Behavior

  • Load a page using json-schema-viewer
  • Open browser console
  • Notice many deprecation notices
  • Run a server-side build using a tool such as Vite, and notice that warnings are emitted during the build phase
console.js:273 [DEPRECATED]: use `useAtomValue` from `jotai` instead. 
    at Divider (webpack-internal:///../../common/temp/node_modules/.pnpm/@[email protected]_@[email protected]_@[email protected]_@stoplight+mar_5xf4cu4e5qhaddtsd35lb2ujpe/node_modules/@stoplight/json-schema-viewer/index.mjs:787:20)
    at div
    at Box (webpack-internal:///../../common/temp/node_modules/.pnpm/@[email protected][email protected][email protected][email protected]/node_modules/@stoplight/mosaic/core.esm.js:759:3)
    at Flex (webpack-internal:///../../common/temp/node_modules/.pnpm/@[email protected][email protected][email protected][email protected]/node_modules/@stoplight/mosaic/core.esm.js:6125:3)
    at div

Expected Behavior

  • Deprecation notices are addressed and longer exist

Possible Workaround/Solution

Solution: upgrade Jotai and/or follow the deprecation notice recommendations.

  • Version used: json-schema-viewer 4.16.1, mosaic 1.53.2
  • Environment name and version (e.g. Chrome 39, node.js 5.4): Chrome 126, Node 20
  • Operating System and version (desktop or mobile): desktop
  • Link to your environment/workspace/project: N/A
@weyert
Copy link
Contributor

weyert commented Aug 11, 2024

Fixed some of it as part of #260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants