Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making better bundle available to the OAS community #27

Open
2 tasks
philsturgeon opened this issue Aug 15, 2021 · 2 comments
Open
2 tasks

Making better bundle available to the OAS community #27

philsturgeon opened this issue Aug 15, 2021 · 2 comments

Comments

@philsturgeon
Copy link

philsturgeon commented Aug 15, 2021

Summary

There are infinite issues on countless packages asking for this new and improved bundling, on our repos (which is why we did it) and various APIDevTools repos.

Can we either, document our fork so people know how the new bundling logic works, or merge our changes back into the upstream so everyone has access to it without needing to switch to our fork?

Tasks

  • Document optimized bundling
  • and/or
  • Merge this functionality upstream to APIDevTools/json-schema-ref-parser so we dont need to maintain this fork

Additional context

It would make a lot of people out there very happy to know we're helping.

@philsturgeon philsturgeon changed the title Making this functionality available to the OAS community Making better bundle available to the OAS community Aug 15, 2021
@marcelstoer
Copy link

Can we either, document our fork so people know how the new bundling logic works [...]

Nit pick: for me this is not "either"; documentation would be helpful with or w/o merging the changes upstream 😉

I am reluctant to attempt to switch to your fork because the tests appear to have been broken since Mar 19, 2021 and no one bothered fix that 🙍‍♂️

@philsturgeon
Copy link
Author

Unnecessary nit pick. If merging changes back upstream they'd be documented there. Otherwise it would be documented here. Come on. If you're about to start a sentence with "nit pick" probably just delete that sentence.

@mnaumanali94 can you get this on somebodies radar as I don't work here anymore? :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants