Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle refs when transforming documents(oas 2 and 3, postman collections, etc...) #94

Open
pytlesk4 opened this issue Jun 9, 2020 · 0 comments
Assignees
Labels
team/platinum-falcons Team Platinum Falcons

Comments

@pytlesk4
Copy link
Contributor

pytlesk4 commented Jun 9, 2020

User story.
When resolving documents in graphite, we bundle the data now. This can result in broken local refs for HTTP operations for example, because when we transform an oas operation to HTTP operations there could be a local ref that no longer exists anymore.

This is causing a lot of complexity in the export service for example, and other parts of stoplight as well. In the export service, because HTTP operations could have broken refs, we don't look them up. Instead, we look up the oas spec, get the transformed HTTP operation, and then bundle the refs.

Describe the solution you'd like
We should move the logic of bundling refs into HTTP-spec. We need to do this for any embedded resource that we work with.

For right now, I think that is HTTP operations and models(embedded JSON Schemas).

Related

https://github.com/stoplightio/platform-internal/pull/2892

@chohmann chohmann added the team/platinum-falcons Team Platinum Falcons label Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team/platinum-falcons Team Platinum Falcons
Projects
None yet
Development

No branches or pull requests

3 participants