Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add customized imagepullsecret support in makefile when run deploy #377

Open
hchenxa opened this issue Apr 4, 2023 · 3 comments
Open

add customized imagepullsecret support in makefile when run deploy #377

hchenxa opened this issue Apr 4, 2023 · 3 comments

Comments

@hchenxa
Copy link
Contributor

hchenxa commented Apr 4, 2023

cc @yanmxa @clyang82

@hchenxa
Copy link
Contributor Author

hchenxa commented Apr 4, 2023

we support the customized imagepullsecret in mcgh CR, since I want to use make deploy to install the mcgh operand on my private cluster, do you think if it's ok to add this? if yes, I can work on this.

@yanmxa
Copy link
Member

yanmxa commented Apr 23, 2023

@hchenxa
I think we have supported the image registry configuration. If there is a difference between our two understandings on this issue, you can give me more information.

@yanmxa
Copy link
Member

yanmxa commented Apr 23, 2023

For the global hub operator, you can specify the IMG to replace the global hub operator image.
And for the global hub operand images, we haven't added the logic to replace the image registry in Makefile, so you can add it if you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants