Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor all shell command from subprocess to sh library to better manage process and close sessions #1

Open
stikkireddy opened this issue Sep 3, 2024 · 0 comments

Comments

@stikkireddy
Copy link
Owner

stikkireddy commented Sep 3, 2024

  • there are some paths where we want the commands to be in a new session and other scenarios where we want the session to be managed to the parent group.
  • there are too many various sections of the code that use subprocess and reimplement the same logic of spawning a new shell command, deciding whether it should be background or foreground, whether it should have a new session or not and if it should have env variables injected or not. Also sometimes you may want to display logs (debugging) and some times not.
  • Ideally we can refactor this into a separate module to focus on handling all these tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant