Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soroban-rpc : add support for fee calculations #623

Closed
tsachiherman opened this issue May 3, 2023 · 2 comments
Closed

soroban-rpc : add support for fee calculations #623

tsachiherman opened this issue May 3, 2023 · 2 comments

Comments

@tsachiherman
Copy link
Contributor

tsachiherman commented May 3, 2023

What ?

The rs-soroban-env now contains library functions to calculate the fees needed by a transaction, based on it's resources.
Our goal is to integrate that into simulateTransaction endpoint in soroban-rpc. This issue is about the second step in the process:
We need to use the exposed fee calculation method we previously created in #622, and use it during simulateTransaction in order to calculate the suggested fees. Then, we need to modify the returned json to include the following:
( all the TransactionResources fields, that you've already used when calling compute_transaction_resource_fee )

  • Number of instructions
  • Number of reads
  • Number of writes
  • Read bytes count
  • Write bytes count
  • Metadata size
  • Transaction size
    ( plus )
  • Fee ( Minimal inclusion fee )
  • RefundableFee

Epic

Dependencies

@2opremio
Copy link
Contributor

2opremio commented May 7, 2023

I think this is fully addressed in #636

@tsachiherman
Copy link
Contributor Author

I think this is fully addressed in #636

Just close both when you're done with 636, as this one was supposed to be the go side and the other on the preflightlib side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants