From 4c512994d091e383d9daf6487b0d53edf67d73b3 Mon Sep 17 00:00:00 2001
From: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
Date: Thu, 27 Jul 2023 17:25:41 -0400
Subject: [PATCH] fix: use uppercase const name (#1043)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

### What

This fixes an issue where Rust Analyzer sometimes complains that:

    constant `symbol` should have UPPER_SNAKE_CASE name

### Why

When using `symbol_short!`, as recommended by the Getting Started →
Hello World tutorial, I was getting confusing warnings from Rust
Analyzer:

<img width="957" alt="image"
src="https://github.com/stellar/rs-soroban-sdk/assets/221614/d7a29fcf-6683-4979-b68b-bab4627d7dd7">

### Known limitations

Why not use this instead?

```rs
Ok(_) => quote! {
    #crate_path::Symbol::short(#s)
}
```
---
 soroban-sdk-macros/src/lib.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/soroban-sdk-macros/src/lib.rs b/soroban-sdk-macros/src/lib.rs
index b0d0e0d43..b3b81f6b7 100644
--- a/soroban-sdk-macros/src/lib.rs
+++ b/soroban-sdk-macros/src/lib.rs
@@ -58,8 +58,8 @@ fn _symbol_short(crate_path: &str, s: &LitStr) -> TokenStream {
     match Symbol::try_from_small_str(&s.value()) {
         Ok(_) => quote! {{
             #[allow(deprecated)]
-            const symbol: #crate_path::Symbol = #crate_path::Symbol::short(#s);
-            symbol
+            const SYMBOL: #crate_path::Symbol = #crate_path::Symbol::short(#s);
+            SYMBOL
         }}
         .into(),
         Err(e) => Error::new(s.span(), format!("{e}"))