Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update asset stats to handle eviction #5422

Open
tamirms opened this issue Aug 13, 2024 · 0 comments
Open

Update asset stats to handle eviction #5422

tamirms opened this issue Aug 13, 2024 · 0 comments

Comments

@tamirms
Copy link
Contributor

tamirms commented Aug 13, 2024

The /assets response includes the following fields (code):

  • number of contracts which have active balances holding the asset
  • total amount of the asset held by all contracts in active balances
  • number of contracts which have expired but not yet evicted balances holding the asset
  • total amount of the asset held by all contracts in expired but not yet evicted balances

We can maintain active balances because LEDGER_ENTRY_RESTORE is functionally equivalent to LEDGER_ENTRY_CREATED changes.

However, we might need to remove or rename the fields which reflect stats for expired but not yet evicted contract asset balances. The fields are currently named archived_contracts_amount and num_archived_contracts which will be misleading because these counts don't include contract asset balances which have been evicted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Blocked
Development

No branches or pull requests

3 participants