Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotator issues #2697

Open
4 tasks
yifanmai opened this issue May 31, 2024 · 0 comments
Open
4 tasks

Annotator issues #2697

yifanmai opened this issue May 31, 2024 · 0 comments
Assignees

Comments

@yifanmai
Copy link
Collaborator

yifanmai commented May 31, 2024

  • RunSpec.annotators should be named RunSpec.annotator_specs
  • Annotators should support concurrency. AnnotatorFactory.get_annotator() should not enforce singletons. The image2structure annotators should be using locks instead. This is a correctness issue - currently, if multiple annotators with different arguments are instantiated, the run could get an annotator with the wrong arguments.
  • Annotator cache directory should be based on the name field, rather than the class name. For instance, the folder for LatexCompilerAnnotator should be latex_compiler, not latexcompiler.
  • Annotator frontend display should support most "simple" JSON objects, but currently only supports lists of dicts (and single dicts after Allow dicts to be displayed in AnnotationsDisplay without a enclosing list #2700)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants