Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New CRAN release? #367

Closed
n-kall opened this issue May 10, 2024 · 14 comments
Closed

New CRAN release? #367

n-kall opened this issue May 10, 2024 · 14 comments

Comments

@n-kall
Copy link
Collaborator

n-kall commented May 10, 2024

There have been several small features included since the last CRAN release, including:

  • thin_draws now does automatic thinning
  • subset_draws has exclude option (currently if a user uses exclude = TRUE with CRAN version, it just ignores it silently, leading to the opposite behaviour as expected)
  • pareto_smooth can be used properly with log weights (in weight_draws, but also the are_log_weights argument)
  • new user facing functions pareto_* diagnostics
  • new extract_variable_array function

Soon there should be larger changes merged (e.g. weighted draws updates, changes to summarise_draws backend to use rvars) which might constitute a larger release. But as the currently merged features are now being used in public case studies (e.g. from @avehtari), perhaps it is a good time to push a point update to CRAN? @paul-buerkner @mjskay

@mjskay
Copy link
Collaborator

mjskay commented May 10, 2024

+1

I am not teaching this quarter, so I will also start to have time to iterate on the bigger things again too. I like the idea of a small release first.

@paul-buerkner
Copy link
Collaborator

I don't really have time to work much on posterior at the moment. Any of these issues that @mjskay, @n-kall or you can address?

@n-kall
Copy link
Collaborator Author

n-kall commented May 14, 2024

Any of these issues that @mjskay, @n-kall or you can address?

Yes, I should be able to prepare PRs for at least those related to pareto diags. A couple of these issues will need decisions regarding naming e.g. #361, #346, which might need further input from others

@mjskay
Copy link
Collaborator

mjskay commented May 14, 2024

I can probably take a look at some of the others in about a week and a half (at a conference currently)

@paul-buerkner
Copy link
Collaborator

Thank you both!

@n-kall
Copy link
Collaborator Author

n-kall commented Jun 26, 2024

Several of the bugs @avehtari listed have now been fixed. @mjskay Any thoughts on the others / should they wait until the next CRAN release?

@paul-buerkner
Copy link
Collaborator

I unfortunately don't have time to work more on posterior at the moment. But I am happy to do a new CRAN release now. @avehtari what are your thoughts?

@avehtari
Copy link
Collaborator

I'd like to include the new Pareto-k-diagnostic vignette #372

@avehtari
Copy link
Collaborator

The Pareto vignette has been merged. I also don't have time now to add or fix anything else, so ok with the new CRAN release

@paul-buerkner
Copy link
Collaborator

Okay. Will submit it today

@mjskay
Copy link
Collaborator

mjskay commented Jun 28, 2024

Thanks - sorry I didn’t get to other issues, it’s been a crazy quarter. I’m hoping to swing back around on some of my outstanding issues this summer, including bigger changes like weighted rvars, but those can wait until after this next release.

@n-kall
Copy link
Collaborator Author

n-kall commented Jul 4, 2024

I see 1.6.0 now on CRAN, thanks @paul-buerkner ! Also, should the pkgdown website be rebuilt or is it an automatic process?

@paul-buerkner
Copy link
Collaborator

paul-buerkner commented Jul 5, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants