Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a consolidated endpoint for current and prior sortitions #5213

Merged
merged 6 commits into from
Sep 23, 2024
Merged

feat: add a consolidated endpoint for current and prior sortitions #5213

merged 6 commits into from
Sep 23, 2024

Conversation

kantai
Copy link
Member

@kantai kantai commented Sep 19, 2024

Description

This implements the lowest hanging fruit for #5200 by adding an endpoint that returns both the current and prior sortitions.

@kantai kantai requested review from a team as code owners September 19, 2024 21:13
@wileyj
Copy link
Contributor

wileyj commented Sep 19, 2024 

error[E0560]: struct `SortitionsView` has no field named `latest_consensus_hash`
Error:   --> stacks-signer/src/tests/chainstate.rs:85:9
   |
85 |         latest_consensus_hash: cur_sortition.consensus_hash,
   |         ^^^^^^^^^^^^^^^^^^^^^ `SortitionsView` does not have this field
   |
   = note: all struct fields are already assigned

For more information about this error, try `rustc --explain E0560`.
error: could not compile `stacks-signer` (lib test) due to 1 previous error

we also need an openapi doc for the signer, would be nice to document this endpoint so it's not forgotten (i'll create an issue for that specifically though - doesn't seem appropriate to add to stacks-core's openapi doc)

@kantai kantai requested a review from a team as a code owner September 20, 2024 02:03
obycode
obycode previously approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

obycode
obycode previously approved these changes Sep 20, 2024
View reviewed changes
obycode
obycode approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saralab saralab added this pull request to the merge queue Sep 23, 2024
Merged via the queue into develop with commit 4b5e9cf Sep 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcnelson jcnelson jcnelson approved these changes

@obycode obycode obycode approved these changes

Assignees
No one assigned
Labels
3.0-must
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kantai @wileyj @jcnelson @obycode @saralab