Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Provide raw transaction data for Emily API deposit operations #595

Closed
1 task
AshtonStephens opened this issue Oct 1, 2024 · 2 comments · Fixed by #601
Closed
1 task

[Feature]: Provide raw transaction data for Emily API deposit operations #595

AshtonStephens opened this issue Oct 1, 2024 · 2 comments · Fixed by #601
Assignees
Labels
emily API that communicates with Signers to trigger sBTC operations.

Comments

@AshtonStephens
Copy link
Collaborator

AshtonStephens commented Oct 1, 2024

Feature - Provide raw transaction data for Emily API deposit operations

1. Description

Emily should return the original deposit and reclaim scripts in all Deposit objects.

1.1 Context & Purpose

The sBTC Signers need access to the reclaim and deposit script binaries from the deposit requests in order to process them. This issue is add those fields to the requests that return the pending deposits for the signers to address.

2. Technical Details:

Emily takes in the fields reclaim and deposit within the initial create request here.

This ticket should add both the reclaim and deposit fields to the objects returned from the API.

To do this the reclaim and deposit fields will also need to be added to the following table structures so they can be stored and retrieved from the DynamoDB table.

2.1 Acceptance Criteria:

  • The reclaim and deposit scripts are available from the GET function calls.

3. Related Issues and Pull Requests (optional):

@AshtonStephens AshtonStephens added the emily API that communicates with Signers to trigger sBTC operations. label Oct 1, 2024
@AshtonStephens AshtonStephens self-assigned this Oct 1, 2024
@AshtonStephens
Copy link
Collaborator Author

Currently fixing an error that's occuring in the integration tests because the first two PRs out of three that were meant to be merged together were merged in, and the third was scrapped: #447.

The full PR doesn't need to be merged, but some of it's changes need to be.

@AshtonStephens
Copy link
Collaborator Author

Added a subset of the features from #447 so that the integration testing runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emily API that communicates with Signers to trigger sBTC operations.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant