Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework Quantity parsing #617

Open
3 tasks
Techassi opened this issue Jul 5, 2023 · 0 comments
Open
3 tasks

Rework Quantity parsing #617

Techassi opened this issue Jul 5, 2023 · 0 comments
Assignees
@Techassi
Labels
release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.

Comments

@Techassi
Copy link
Member

Techassi commented Jul 5, 2023 •
edited by fhennig
Loading

Our custom Quantity parsing doesn't match K8s behavior completely. This issue tracks the improvement of our parsing. This might break tests.

Parsing spec: https://kubernetes.io/docs/reference/kubernetes-api/common-definitions/quantity/

This issue was raised after an internal arch meeting where the code style around resource specifications was discussed.

Acceptance criteria
Beta Give feedback
@Techassi Techassi self-assigned this Jul 5, 2023
@Techassi Techassi mentioned this issue Dec 5, 2023
Open
@fhennig fhennig added the release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Techassi Techassi

Labels
release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fhennig @Techassi