Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file:// protocol to self links that currently don't have a protocol #1347

Open
Tracked by #1375
gadomski opened this issue Jun 3, 2024 · 4 comments
Open
Tracked by #1375
Assignees
Milestone

Comments

@gadomski
Copy link
Member

gadomski commented Jun 3, 2024

xref radiantearth/stac-spec#1281, but it seems likely that at some point in the future self links will be required to have a protocol (i.e. absolute filesystem paths won't be enough). We should update to pystac to write file:// absolute paths to future-proof ourselves and help ecosystem adoption.

@jsignell jsignell added this to the STAC spec version 1.1.0 milestone Jul 31, 2024
@jsignell jsignell self-assigned this Aug 6, 2024
@jsignell
Copy link
Member

jsignell commented Aug 6, 2024

Does this also imply that RELATIVE_PUBLISHED is no longer a valid catalog type?

@gadomski
Copy link
Member Author

gadomski commented Aug 6, 2024

🤔 I'm not sure why it would be invalid ... per best practices:

This is a self-contained catalog as described above, except it includes an absolute self link at the root to identify its online location.

I think a file:///path/to/something href would count as an absolute self link?

@jsignell
Copy link
Member

jsignell commented Aug 6, 2024

Oh ok so absolute in this context just means a url with a protocol. Not as in absolute vs relative path?

@gadomski
Copy link
Member Author

gadomski commented Aug 7, 2024

Oh ok so absolute in this context just means a url with a protocol. Not as in absolute vs relative path?

Yeah, I think that text from the best practices is now a bit confusing since a href with a protocol is probably always absolute ... I can't think of an example of a protocol://-style href that could be relative?

@gadomski gadomski modified the milestones: STAC spec version 1.1.0, v1.11 Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants