Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where npmVersion is ignored #329

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevinamasur
Copy link

Right now when I specify an npmVersion and set download = true the npmVersion I specified is being installed but not being used by NpmTasks. Instead, the npm bundled with the node setup is used.

I think the npmVersion is always getting resolved to null in the conditional.

node {
	npmVersion = '5.8.0'
	download = true
}
task printNpmConfigInfo(type: NpmTask) {
 args = ['config', 'list']
}

When running with the above the configured npm run is 6.5 located in the nodejs bin folder, not the defined npm.

user-agent = "npm/6.5.0 node/v6.9.1 darwin x64"

; node bin location = /.gradle/nodejs/node-v6.9.1-darwin-x64/bin/node

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants