Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New agent test breaks deployments #5455

Closed
kfox1111 opened this issue Sep 3, 2024 · 2 comments
Closed

New agent test breaks deployments #5455

kfox1111 opened this issue Sep 3, 2024 · 2 comments
Labels
priority/backlog Issue is approved and in the backlog priority/urgent Issue is approved and is must be completed in the assigned milestone
Milestone

Comments

@kfox1111
Copy link
Contributor

kfox1111 commented Sep 3, 2024

  • Version: 1.10.2

#5298

Added a test to ensure that the agent has a svid. In the helm chart, in most configurations that currently is not true.

Its even harder to deal with in nested configurations where root-server -> nested-server may already have an entry, but root-server -> root-agent currently may not.

This patch breaks previously working configurations without potentially complicated reconfiguration.

It is more work in some situations then a patch release implies.

I suggest we revert this patch, cut a 1.10.3 asap, and then re-add the patch with an appropriate user configuration warning at 1.11.0. This will give users a chance to consider the config changes required to properly upgrade in a more cautious way.

@kfox1111
Copy link
Contributor Author

kfox1111 commented Sep 3, 2024

After digging further, it seems like it may be a different issue then as described. Closing for now, and will reopen if it really is a problem.

@MarcosDY MarcosDY added this to the 1.11.0 milestone Sep 3, 2024
@MarcosDY MarcosDY added priority/backlog Issue is approved and in the backlog priority/urgent Issue is approved and is must be completed in the assigned milestone labels Sep 3, 2024
@MarcosDY MarcosDY modified the milestones: 1.11.0, 1.10.3 Sep 5, 2024
@MarcosDY
Copy link
Collaborator

MarcosDY commented Sep 5, 2024

solved in 1.10.3, and reopend #5297

@MarcosDY MarcosDY closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/backlog Issue is approved and in the backlog priority/urgent Issue is approved and is must be completed in the assigned milestone
Projects
None yet
Development

No branches or pull requests

2 participants