Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spire & OIDC Vault tutorial: Fails to pull the oidc-discovery-provider:1.5.1 image and the oidc discovery provider configuration is outdated #105

Open
Dimss opened this issue Dec 24, 2022 · 1 comment

Comments

@Dimss
Copy link

Dimss commented Dec 24, 2022

  • Seams like the image within the Spire OIDC & Vault and should be replaced with ghcr.io/spiffe/oidc-discovery-provider:1.5.3
  • The readinessProbe for the spire-oidc should be set to path: /ready
  • The domain in the oidc-dp-configmap.yaml should be configured as a list: domains = ["MY_DISCOVERY_DOMAIN"]

In addition I do not understand why the ingress.yaml file is a part of the tutorial.

  • Under requirements, I did not found any request to deploy K8s Ingress Controller
  • Even if I deployed some K8s Ingress Controller on my K8s cluster, it's seems that I've to have the Cert Manager? Or should I provide TLS certs for the ingress manually? The Ingress rules include this directive: secretName: oidc-secret but in fact there is no such a secret with TLS keys.
  • Why the tutorial requests ingress rule, while server-oidc-service.yaml is a LoadBalancer service & the DNS configured to the external IP of that service.
@TheAshwanik
Copy link

TheAshwanik commented Feb 4, 2023

Thank you.
Editing the statefulset with these values does not work. I had to delete the pod and it then recreated successfully and running.

Dimss added a commit to Dimss/spire-tutorials that referenced this issue Jul 26, 2023
Signed-off-by: Dmitry Kartsev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants