Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a way to do real health checks? #101

Open
marcofranssen opened this issue Feb 24, 2023 · 0 comments
Open

Is there a way to do real health checks? #101

marcofranssen opened this issue Feb 24, 2023 · 0 comments

Comments

@marcofranssen
Copy link
Contributor

Currenlyt healthz.Ping is used as an implementation for health checks.

if err := mgr.AddHealthzCheck("healthz", healthz.Ping); err != nil {
setupLog.Error(err, "unable to set up health check")
return err
}
if err := mgr.AddReadyzCheck("readyz", healthz.Ping); err != nil {
setupLog.Error(err, "unable to set up ready check")
return err
}

Probably we could do better here by checking server socket or things like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant