Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIFFE Helper releases #165

Open
MarcosDY opened this issue Jun 6, 2024 · 7 comments
Open

SPIFFE Helper releases #165

MarcosDY opened this issue Jun 6, 2024 · 7 comments
Milestone

Comments

@MarcosDY
Copy link
Collaborator

MarcosDY commented Jun 6, 2024

Add automation to create images when releasing spiffe-helper,

Acceptance criteria:

  • use scratch image as base
  • images are pushed into ghcr.io

Optional:

  • Release windows images
@gflarity
Copy link
Contributor

gflarity commented Jun 6, 2024

Not sure how this typically managed, but seems like it should be possible:

  1. trigger a github workflow when there's a new tag. Say of the format v#.#.# (like v1.0.0)
  2. create a new release via a github workflow: https://trstringer.com/github-actions-create-release-upload-artifacts/

I'll investigate further (see how it's done in other spiffe projects) and submit a PR if a maintainer can give the nod that it's likely to be accepted.

Edit:
Something like: https://github.com/spiffe/spire/blob/main/.github/workflows/release_build.yaml

@MarcosDY
Copy link
Collaborator Author

MarcosDY commented Jun 6, 2024

You can follow the same structure we use for SPIRE or spire-controller-manager
I suggest something more similar ton controller manager, because SPIRE is more complex

@keeganwitt
Copy link
Contributor

@gflarity
Copy link
Contributor

Isn't there already a workflow that matches the spire-controller-manager (https://github.com/spiffe/spiffe-helper/blob/main/.github/workflows/release_build.yaml matching https://github.com/spiffe/spire-controller-manager/blob/main/.github/workflows/release_build.yaml)?

I'll take a look. Who's the current maintainer who would actually create a release?

@keeganwitt
Copy link
Contributor

keeganwitt commented Jun 12, 2024

I can't see the member list, but I know @MarcosDY can and I think @faisal-memon did the last release.

@gflarity
Copy link
Contributor

👍 I'm swamped but this is still on my todo list. Hopefully take a look and then ping them next week.

@faisal-memon faisal-memon added this to the 0.8.0 milestone Sep 8, 2024
@faisal-memon faisal-memon modified the milestones: 0.8.0, 0.9.0 Sep 11, 2024
@faisal-memon
Copy link
Collaborator

@MarcosDY Docker containers are now published with distroless as base. Is it ok to close this as completed and track windows builds with a separate issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants