Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new ParseRawWithHint() func for X.509-SVID #250

Open
chiragk25 opened this issue Dec 12, 2023 · 0 comments
Open

Add new ParseRawWithHint() func for X.509-SVID #250

chiragk25 opened this issue Dec 12, 2023 · 0 comments

Comments

@chiragk25
Copy link

Currently X.509-SVID parsing from raw ASN.1 DER bytes doesn't take into account the SVID hint capability, which requires adding it explicitly to the SVID struct once parsing is complete. Eg here: https://github.com/spiffe/go-spiffe/blob/v2.1.6/v2/workloadapi/client.go#L451-L454.

Maybe having a new function would make things cleaner?

func ParseRawWithHint(certBytes, keyBytes []byte, hint string) (*SVID, error)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chiragk25