Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Singular property name problem with namespace and namespaces #328

Closed
armintaenzertng opened this issue May 11, 2023 · 2 comments
Closed

Singular property name problem with namespace and namespaces #328

armintaenzertng opened this issue May 11, 2023 · 2 comments
Milestone
3.0-rc2

Comments

@armintaenzertng
Copy link
Contributor

If we want to keep property names singular, we have to come up with a different name for either namespace or namespaces.
@goneall
Copy link
Member

goneall commented May 11, 2023

Suggest namespaces -> namespaceMap (note lower case n to distinguish it from the class by the same name)

@armintaenzertng armintaenzertng mentioned this issue May 15, 2023
Merged
@goneall goneall added this to the 3.0-rc2 milestone Jun 3, 2023
@goneall
Copy link
Member

goneall commented Jul 11, 2023

Closing this issue as the namespaces are no longer in the model once #411 is merged

From tech call on 11 July 2023

@goneall goneall closed this as completed Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0-rc2
Development

No branches or pull requests
2 participants
@goneall @armintaenzertng