Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated function call in PSF_phot_01 throwing error in notebook #128

Open
rosteen opened this issue Mar 6, 2020 · 4 comments · May be fixed by #129
Open

Outdated function call in PSF_phot_01 throwing error in notebook #128

rosteen opened this issue Mar 6, 2020 · 4 comments · May be fixed by #129
Assignees
@rosteen

Comments

@rosteen
Copy link

rosteen commented Mar 6, 2020 •
edited
Loading

There is a tiny bug in this JWST PSF notebook: webbpsf.utils.to_griddedpsfmodel now takes ext_data and ext_header as arguments rather than ext, so the first code cell under Creating a PSF model fails. Updating the function call to use the new arguments allows the block to run.
@pllim
Copy link
Contributor

pllim commented Mar 6, 2020

Just for clarity, what version of webbpsf you are running now? cc @mperrin

@rosteen
Copy link
Author

rosteen commented Mar 6, 2020

I'm using webbpsf 0.9.0, installed via pip

@pllim
Copy link
Contributor

pllim commented Mar 6, 2020

Thanks for the info. Do you have plans to open a pull request to fix this?

@rosteen
Copy link
Author

rosteen commented Mar 6, 2020

Already did so, here

@rosteen rosteen linked a pull request Mar 6, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rosteen rosteen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes issue 128 rosteen/notebooks
2 participants
@pllim @rosteen