Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom accepts header not used in requests #5

Closed
jaredmoody opened this issue Oct 31, 2018 · 1 comment
Closed

Custom accepts header not used in requests #5

jaredmoody opened this issue Oct 31, 2018 · 1 comment

Comments

@jaredmoody
Copy link
Contributor

In order to use this gem, I have to specify the previous API version in the accepts header as I described in #4:

ConnectWise::ApiClient.default.default_headers['Accept'] = "application/vnd.connectwise.com+json; version=3.0.0"

However, several of the API classes call @api_client.select_header_accept(['application/json']) which overwrites my accept header.

I propose that select_header_accept be modified to respect default headers.
@jaredmoody
Copy link
Contributor Author

This is closed by #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaredmoody