Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort by issues #199

Open
mackski opened this issue Feb 12, 2016 · 4 comments
Open

Sort by issues #199

mackski opened this issue Feb 12, 2016 · 4 comments

Comments

@mackski
Copy link

mackski commented Feb 12, 2016

  1. Sort by link not clickable in Chrome.
  2. Change sort by (in firefox) does not work. (also manually constructing URL does not work)
    eg:
    #sort=alph
    #sort=date
@robhrt7
Copy link
Member

robhrt7 commented Feb 12, 2016

Hi,

Can you please specify the version you're using, is it the latest 0.5.6?

On 0.5.6, which is used by sourcejs.com both sorting by date and alph is working:

https://sourcejs.com/docs/#sort=date

image

@mackski
Copy link
Author

mackski commented Feb 13, 2016

Appears to be a CSS issue, the overlapping div can be seen here:
Adding: float:left to .source_col__23 resolves the issue.

What's strange is that sourcejs.com does not do this, although it shares the exact same css.

![snip_20160213160750](https://cloud.githubusercontent.com/assets/4234669/13026231/01ce4c68-d26c-11e5-8a70-dbe2009d5828.png

@mackski
Copy link
Author

mackski commented Feb 13, 2016

I can now confirm the offending css is: .source_login which has a height of 40px.
Setting this to display: none, or height:0 also resolves the issue.

@robhrt7
Copy link
Member

robhrt7 commented Feb 16, 2016

Oh, now I follow the problem. Will investigate this and mark as bug. PR to 0.6.0-devcould greatly help speed up the process.

Could you please also show the source code of your overridden header template?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants