Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript indexer doesn't emit the language field scip.language #263

Open
donsbot opened this issue Jun 26, 2023 · 0 comments
Open

TypeScript indexer doesn't emit the language field scip.language #263

donsbot opened this issue Jun 26, 2023 · 0 comments
Labels
graph/scip-typescript team/graph

Comments

@donsbot
Copy link

donsbot commented Jun 26, 2023

When combining SCIP data from many sources it is very useful to know the language of the file.

message Document {
  string language = 4;

I believe scip-typescript may be setting this to "" .

there's also something funky with non-utf8 in the symbol fields.

$ protoc --decode scip.Occurrence scip.proto < /tmp/index.scip
E0626 17:07:01.064803 1569665 wire_format_lite.cc:626] String field 'scip.Occurrence.symbol' contains invalid UTF-8 data when parsing a protocol buffer. Use the 'bytes' type if you intend to send raw bytes.
donsbot added a commit to donsbot/Glean that referenced this issue Jun 26, 2023
@donsbot
[scip][typescript] Port typescript indexer from LSIF to SCIP
aa3f417 
Faster, more precise. Aligned with go and rust-analyer

Currently blocked on sourcegraph/scip-typescript#263
but we might be able to work around this
donsbot added a commit to donsbot/Glean that referenced this issue Jun 27, 2023
@donsbot
[scip][typescript] Port typescript indexer from LSIF to SCIP
aacd1cd 
Faster, more precise. Aligned with go and rust-analyer

Currently blocked on sourcegraph/scip-typescript#263
but we might be able to work around this
@donsbot donsbot mentioned this issue Jun 27, 2023
Closed
facebook-github-bot pushed a commit to facebookincubator/Glean that referenced this issue Jun 28, 2023
@donsbot @facebook-github-bot
Port typescript indexer from LSIF to SCIP (#344)
9b6fd55 
Summary:
Faster, more precise. Aligned with go and rust-analyer

Also works around  sourcegraph/scip-typescript#263 by setting an optional language hint.

Pull Request resolved: #344

Test Plan: will need to fix the relative path prefix to the indexer as it bakes in the full path

Reviewed By: simonmar

Differential Revision: D47050745

Pulled By: donsbot

fbshipit-source-id: 582c1cd7b0fc69daabcae64770cda3320ba273ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
graph/scip-typescript team/graph
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@donsbot @varungandhi-src