Bumping to 1.1.3 requires extra attention

[TomerFi]

Hey @sormuras

Just bumped into something weird and figured I'll let you know.
It's not really an issue, if anything, I think it's an improvement.

After bumping from 1.1.2 to 1.1.3 in TomerFi/hebcal-api@1637df7.
Some of my test cases started failing with the standard:

java.lang.IllegalAccessError: class A (in module b) cannot access class C (in module d) because module b does not read module d

Not a big deal, I've added the required reads permissions in TomerFi/hebcal-api@c7f7efd and that was it.
It actually makes more sense now, I think...

Nevertheless,
I figured I'll let you know,
since downgrading back to 1.1.2 solved this for me as well.
:-)

[sormuras]

Thanks for the heads-up, Tomer.

Looking briefly at hebcal-api's source file layout, I think too that those reads directives were missing in the module-info.test configuration file.
Yet, that side-effect wasn't expected... indicating a lack of (integration) tests, especially regarding module-info.test support.

[TomerFi]

I second that.

[sormuras]

Fine. So, #80 can be merged, I guess.

[zregvart]

@sormuras well, compile != provided :( (not really relevant)

[zregvart]

Yeah, though I've looked at the MavenProject source code, the #80 will bring in compile, provided, system and runtime.

So the difference from previous state in #77 is the addition of provided and system, which I think is okay.

Ref. https://github.com/apache/maven/blob/5acdfb665035c5e57c50a9f8198dee53da674df6/maven-core/src/main/java/org/apache/maven/project/MavenProject.java#L346-L371
Ref. https://github.com/apache/maven/blob/5acdfb665035c5e57c50a9f8198dee53da674df6/maven-core/src/main/java/org/apache/maven/project/MavenProject.java#L403-L424

[sormuras]

Thanks for the discussion and the investigations, Tomer and Zoran. Very much appreciated!

Let's see what happens next, when #80 is merged.