Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purl format updates #44

Open
zendern opened this issue Oct 6, 2020 · 0 comments
Open

Purl format updates #44

zendern opened this issue Oct 6, 2020 · 0 comments

Comments

@zendern
Copy link
Contributor

zendern commented Oct 6, 2020

When building purls to be sent over we currently use different formats for debian, alpine, fedora, etc.

From the docs here
https://ossindex.sonatype.org/doc/coordinates

It appears we should be passing like we do in the debian case but for the others.

The goal of this issue is

  1. Make sure that is how we should do it?? Maybe do a little code spelunking to determine if we did it for a reason or not.
  2. Make all the things more consistent.

To help move this forward, I've decoupled the purl format updates. Maybe we can tackle that as a separate PR. Since we're not passing os anymore, apt.go has to hard code Debian while both Alpine and Fedora don't include OS at all. It feels like we should be consistent one way or the other, but that doesn't need decided here.

To avoid strewing os references all over, I just updated the switch to support either --os or --package-manager strings. Seems to work locally, and also updated tests to cover both until the deprecated bits can be fully removed.

Originally posted by @deadlysyn in #42 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant