Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an flag setting kubetap-mitmproxy repo to pull #17

Open
mengzyou opened this issue Jun 17, 2022 · 1 comment
Open

Add an flag setting kubetap-mitmproxy repo to pull #17

mengzyou opened this issue Jun 17, 2022 · 1 comment

Comments

@mengzyou
Copy link

Feature Description

Kubetap is a great tool to debug web application running k8s cluster.
But it's depend on a kubetap-mitmproxy image default from gcr.io registry.
I'm in China, and can not access to gcr.io normally, so allways fails when I execute kubectl tap on command.

Failed to pull image "gcr.io/soluble-oss/kubetap-mitmproxy:latest": rpc error: code = Unknown desc = Error response from daemon: Get https://gcr.io/v2/: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)

Hope can add an option flag to set this image repo to pull. Then we can push this image to other registry (like dockerhub).

Proposed Solution

Add a flag (for example --proxy-image) to set a image repo replacing default one.

@mengzyou
Copy link
Author

Sorry, seems it will use 3 images:

	defaultImageHTTP = "gcr.io/soluble-oss/kubetap-mitmproxy:latest"
	defaultImageRaw  = "gcr.io/soluble-oss/kubetap-raw:latest"
	defaultImageGRPC = "gcr.io/soluble-oss/kubetap-grpc:latest"

Maybe take another solution is adding a flag

--registry=[gcr|dockerhub|...]

and sync the images to other registies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant