New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`createButton` isn't passing user props to the element #69

Open

thetarnav opened this issue Aug 31, 2022 · 0 comments · May be fixed by #72

Labels

bug

Member

thetarnav commented Aug 31, 2022 •

edited

Loading

User props such as class or children aren't being passed down to returned buttonProps.
The button doesn't seem clickable with Enter too..

export const Button: ParentComponent<
  JSX.IntrinsicElements['button'] & AriaButtonProps
> = props => {
  let ref!: HTMLButtonElement
  const { buttonProps } = createButton(props, () => ref)

  return <button {...buttonProps} ref={ref} />
};

// class and children aren't being applied
<Button class="btn">Hello</Button>

repro: https://stackblitz.com/edit/createbutton-props-issue?file=index.tsx

The text was updated successfully, but these errors were encountered:

thetarnav added the bug label

This was referenced Aug 31, 2022

remove props.children from button readme #67

Merged

Fix passing user props through #72

Open

thetarnav linked a pull request

that will close this issue

Fix passing user props through #72

Open

2 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment