-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement tools that help with reading compiled contracts #1455
Comments
Hi @kkawula can i please be assigned to this issue? |
Hi @ShantelPeters yes, you can take it. Can you give pr this week? FYI: we have similar functionality in our test, so that can inspire you. load_contract |
Thank you ser 🫡 @kkawula |
Hi @ShantelPeters, can you create a pull request this week? |
Okay sir @kkawula |
I have an Idea on how to do this i dont know if i can contribute to this |
Hi @Constantine234! Currently someone is working on this issue, so at this time you can't, but we have a few issues labeled as |
Hi @Constantine234 this issue is free to take, are you still interested in it? |
yes sir I am interested @kkawula |
@kkawula when will you want this to be ready? |
It would be great if manage to open pull request in one week and request me for the first review |
okay so that is to say it should be done before next week right ? @kkawula |
yes, something like that |
then trust me on this is done I will start working on it tomorrow to Wednesday @kkawula |
@kkawula Pull request will be done tomorrow thank you |
Hi @kkawula, i would like to contribute to this issue if noone else is working on it. Also, can we connect on telegram to discuss? |
Hey @ManvithaMolakala! |
Hey @ManvithaMolakala! |
I am applying to this issue via OnlyDust platform. My background and how it can be leveragedIntermediate in Python and Java. How I plan on tackling this issueInitialization:The class takes in file paths for the Sierra, CASM, and ABI files.Methods:read_sierra(): Loads the Sierra file.read_casm(): Loads the CASM file.read_abi(): Loads the ABI file.calculate_compiled_contract_casm(): Uses the loaded data to compute a unique value for the compiled contract (this is a placeholder and should be replaced with the actual computation).Usage:Create an instance of ScarbOutputImporter, provide the file paths, and call load_all() to load all the data.Then, call calculate_compiled_contract_casm() to compute the result.This structure should give you everything needed to handle importing the Scarb output and computing the required values for declaring the contract. You can extend the placeholder logic in calculate_compiled_contract_casm() based on how the contract declaration process is defined in Starknet. |
I am applying to this issue via OnlyDust platform. My background and how it can be leveragedI have been implemented tools using Python and i can borrow concepts from similar implementations to handle this issue. How I plan on tackling this issueI will use inspiration from the https://github.com/software-mansion/starknet.py/blob/development/starknet_py/tests/e2e/fixtures/misc.py#L72C5-L72C18 , then i will test the implementation solution if it solves the problem i will go ahead and write a documentation on how the tool can be used. |
Hi @kkawula Please confirm the following approach for this issue: |
Hi @ManvithaMolakala
|
Add a class/methods that helps with importing scarb output. It gives you everything needed to declare the contract.
Additionally, add an example in docs.
For reference our implementation for test purposes load_contract.
The text was updated successfully, but these errors were encountered: