Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample-dagger2-rx: fix Dagger 2 scopes #91

Closed
ersin-ertan opened this issue Oct 9, 2015 · 3 comments
Closed

sample-dagger2-rx: fix Dagger 2 scopes #91

ersin-ertan opened this issue Oct 9, 2015 · 3 comments

Comments

@ersin-ertan
Copy link

I've incorporated the dagger 2 scopes with subcomponents for the project(as a practice exercise, which could lead up to fixing the mail sample in issue #39), if you want to check it out. I could also create a pull request if you wanted that sample updated.

If you do check it out, what do you think of the design/components and scoping.

@sockeqwe
Copy link
Owner

sockeqwe commented Oct 9, 2015

Thanks, i will check it out next week, but I'm not an dagger 2 expert 😄

@IgorGanapolsky
Copy link
Contributor

@ersin-ertan What is your ReposComponent a subcomponent of?

@ersin-ertan
Copy link
Author

ersin-ertan commented Feb 20, 2016

It appears to be ActivityComponent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants