Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revision() has called but .manifestFile() always returns 'revision() must be called first!' error. #159

Open
gemilangpermata opened this issue Oct 20, 2016 · 2 comments

Comments

@gemilangpermata
Copy link

rev-all1
rev-all2

@wbprice
Copy link
Contributor

wbprice commented Feb 14, 2017

I was getting the same error message, but was able to resolve it after fixing the glob used to match files to pipe to RevAll. You might have better luck with

gulp.src(['.build/**/*.*'])

@JetFault
Copy link

I'm getting the same thing with this:

gulp.task('rev', () => {
  const target = global.target;
  const timestamp = global.timestamp;
  const timestampDirs = `./*/dist/${timestamp}`;

  return gulp.src([`${timestampDirs}/**`, `!${timestampDirs}`])
    .pipe(rename(path => {
      path.dirname = path.dirname.replace(`/dist/${timestamp}`, '');
    }))
    .pipe(rev.revision({
      fileNameManifest: global.assets_manifest_filename,
      prefix: global.cloudfrontCdnUrl
    }))
    //.pipe(revReplace())
    .pipe(gulp.dest(target + 'dist'))
    .pipe(rev.manifestFile())
    .pipe(gulp.dest(target))
});

It worked fine with gulp-rev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants