Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to JUnit 5 and refactor tests #64

Closed
milesziemer opened this issue Aug 23, 2022 · 1 comment
Closed

Upgrade to JUnit 5 and refactor tests #64

milesziemer opened this issue Aug 23, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@milesziemer
Copy link
Contributor

milesziemer commented Aug 23, 2022 •
edited
Loading

This will make it easier to look at and understand test, and make it easier to add new tests or change existing tests.

A working list of desired changes:

  • Standardization of test cases across different unit tests. For example, definitions and hover tests use the same locations as input parameters.
  • Combining of unit tests for IDL 1 and 2. Both sets of unit tests test the same interfaces, they just have different test cases.
  • Reduce code duplication by creating more generic assert methods that construct request params and call LSP functionality
  • Split up test .smithy files into separate test cases
  • Parameterized tests
  • Re-useable test setups that require little to no boilerplate in test methods
@milesziemer milesziemer added the enhancement New feature or request label Aug 23, 2022
@milesziemer milesziemer mentioned this issue Aug 26, 2022
Merged
@milesziemer
Copy link
Contributor Author

Done in #146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@milesziemer