Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error of unread message count #16

Open
mayyuen318 opened this issue Feb 20, 2017 · 2 comments
Open

Error of unread message count #16

mayyuen318 opened this issue Feb 20, 2017 · 2 comments
Assignees
@rickmak
Labels
PM Acceptance Skygear SDK Bug

Comments

@mayyuen318
Copy link

mayyuen318 commented Feb 20, 2017 •
edited by rickmak
Loading

screen shot 2017-02-20 at 12 07 53 pm

There is a unread message at the top and next to the test2 conversation. However, I am the one sending the message and not yet received message from test2. Could you check whether it is an error from Chat SDK or the demo issue?

Let me know if it is SDK and if the issue already open on Chat SDK repo
@mayyuen318
Copy link
Author

Boris,
After discussing with Rick, he mentioned there is an alternative way to get the count right.
Kindly find Rick's reply here and solve the issue? SkygearIO/chat-SDK-JS#22 (comment)

@akiroz akiroz changed the title Error of unread message Error of unread message count Feb 24, 2017
@akiroz
Copy link
Collaborator

akiroz commented Feb 24, 2017 •
edited
Loading

The unread_count is still not right even after calling markAsLastMessageRead.
The last_message is set but unread_count hasn't been cleared:
screenshot from 2017-02-24 16-16-29

@rickmak rickmak assigned rickmak and unassigned akiroz Feb 24, 2017
rickmak added a commit that referenced this issue Apr 21, 2017
@rickmak
Change to use UserConversation as SDK suggest
90fabc3 
refs #16
rickmak added a commit that referenced this issue Apr 21, 2017
@rickmak
Call markAsLastMessageRead to update the unread count
4469044 
refs #16
rickmak added a commit that referenced this issue Apr 21, 2017
@rickmak
Update the unread count from remote update
b518aec 
refs #16
rickmak added a commit that referenced this issue Apr 21, 2017
@rickmak
Correct update unread count on select conversation
30069c0 
refs #16
rickmak added a commit that referenced this issue Apr 21, 2017
@rickmak
Fix unread count bug
39d711a 
refs #16
rickmak added a commit to rickmak/react-chat-demo that referenced this issue Aug 11, 2017
@rickmak
Hot fix the unread count bug on selected conversation
5631d40 
refs skygear-demo#16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rickmak rickmak

Labels
PM Acceptance Skygear SDK Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rickmak @mayyuen318 @akiroz