Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] pkg/vanflow/eventsource tests are flaky #1738

Open
c-kruse opened this issue Oct 21, 2024 · 0 comments
Open

[v2] pkg/vanflow/eventsource tests are flaky #1738

c-kruse opened this issue Oct 21, 2024 · 0 comments
Assignees

Comments

@c-kruse
Copy link
Contributor

c-kruse commented Oct 21, 2024

Describe the bug
These unit tests are pretty fraught with timing sensitive assertions - the level they were written at counts on lots of asynchronous goings ons, and they were written such that I could sub in a real router container or a mock implementation.

For whatever reason I can run these tests in the most adverse conditions I can manage on my PC with count 500 and not come across these errors.

I plan to rewrite these in a less time-sensitive and async way.

@c-kruse c-kruse self-assigned this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant