-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/avatar #6
base: main
Are you sure you want to change the base?
Feat/avatar #6
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This comment was marked as outdated.
This comment was marked as outdated.
@endigo9740 I tried Rich's suggestion to check the natural-width and height of the image but then if the image is not loaded on initialization (we are getting images from some-website usually) the width and height will be 0 so the src will be replaced with the fallback. for now I've gone ahead and deleted the fallback props, but we should decide if we want to handle this inside the avatar or just ignore it. |
@Mahmoud-zino that's weird. Hmm, well something to monitor as Svelte 5 progresses. Maybe they'll resolve this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few things!
Note:
only svelte is implemented as @endigo9740 requested.
I didn't implement click and keyboard events because of a11y.