Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current rack dependency version causes conflict with modern rackup versions #562

Open
64kramsystem opened this issue Jul 31, 2024 · 13 comments

Comments

@64kramsystem
Copy link

The rack dependency version, ~>2.2, causes conflicts with modern rackup versions (e.g. 2.1.0); it should be verified and upgraded to a modern version (e.g. ~>3.1).

@sj26
Copy link
Owner

sj26 commented Jul 31, 2024

How does it cause conflicts?

@64kramsystem
Copy link
Author

Try installing rack version ~>2.2, then the latest rackup version; you'll get a conflict on the rackup binary.

@sj26
Copy link
Owner

sj26 commented Jul 31, 2024

Ah yes, I can reproduce:

$ gem install mailcatcher
...
Successfully installed rack-2.2.9
...

$ gem install rackup
Fetching rack-3.1.7.gem
Fetching rackup-2.1.0.gem
Successfully installed rack-3.1.7
rackup's executable "rackup" conflicts with rack
Overwrite the executable? [yN]
ERROR:  Error installing rackup:
	"rackup" from rackup conflicts with installed executable from rack

Sounds like a bump is in order. It might be possible now, given the dependencies on thin and websocket-driver have been unwound a little.

@aried3r
Copy link

aried3r commented Aug 7, 2024

Do you think this would potentially solve #560?

@sj26
Copy link
Owner

sj26 commented Aug 7, 2024

No. #560 is an error in how homebrew has packaged mailcatcher.

Workaround for that is don’t install mailcatcher with homebrew. Just:

gem install mailcatcher

@dsandstrom
Copy link

No. #560 is an error in how homebrew has packaged mailcatcher.

Workaround for that is don’t install mailcatcher with homebrew. Just:

gem install mailcatcher

Results in

rack's executable "rackup" conflicts with rackup
Overwrite the executable? [yN]
ERROR:  Error installing mailcatcher:
	"rackup" from rack conflicts with installed executable from rackup

I don't want to overwrite the executable so can't install

@sj26
Copy link
Owner

sj26 commented Aug 13, 2024

Just press “n” for now

@dsandstrom
Copy link

Just press “n” for now

Right, that results in not installing the gem

@64kramsystem
Copy link
Author

No. #560 is an error in how homebrew has packaged mailcatcher.
Workaround for that is don’t install mailcatcher with homebrew. Just:

gem install mailcatcher

Results in

rack's executable "rackup" conflicts with rackup
Overwrite the executable? [yN]
ERROR:  Error installing mailcatcher:
	"rackup" from rack conflicts with installed executable from rackup

I don't want to overwrite the executable so can't install

If you can, uninstall all the versions of rackup, and install version 1.0; it won't conflict.

@sj26
Copy link
Owner

sj26 commented Aug 13, 2024

Just press “n” for now

Right, that results in not installing the gem

No, it should install the gem, it just won’t link that particular executable (which isn’t required, at least for mailcatcher)

@dsandstrom
Copy link

If you can, uninstall all the versions of rackup, and install version 1.0; it won't conflict.

Trying to get mailcatcher to work with rack 3, rackup 2.1

@dsandstrom
Copy link

Just press “n” for now

Right, that results in not installing the gem

No, it should install the gem, it just won’t link that particular executable (which isn’t required, at least for mailcatcher)

I must be missing something

@dsandstrom
Copy link

I started to look into what it would take to update this gem so it works with rack 3. Unfortunately, I couldn't even get gems to install.

The limiting factor starts with sprockets-sass. Sprockets v4 supports rack 3, but sprockets-sass hasn't been updated to support that version.

https://github.com/petebrowne/sprockets-sass/blob/master/sprockets-sass.gemspec#L39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants