Redundant and allocating method for matrixes

[ctessum]

Here:

GridInterpolations.jl/src/GridInterpolations.jl

Line 142 in a955ae2

interpolate(grid::AbstractGrid, data::Matrix, x::AbstractVector) = interpolate(grid, map(Float64, data[:]), x)

Because:

julia> Matrix
Matrix (alias for Array{T, 2} where T)

and there is already a method for Array, it seems like this method isn't needed, so could be deleted, and it reallocates the entire array, so should be avoided. But maybe I misunderstand something?

[mykelk]

Good question. Any thoughts @zsunberg ?

[zsunberg]

After looking at the blame, the best I can tell is that it was meant to flatten the matrix into a vector, but I don't think that would make a difference in the result. I think we could remove it.

I wish we had up-to-date code coverage set up, but according to the latest coverage result from 2021, it is a covered line, so it should be safe to remove if the tests pass 😆 .

[mykelk]

Sounds good. It looks like it is part of #47 !

[ctessum]

I believe the overall effect of this method is to convert any type of matrix to a float64 matrix before doing interpolation. However, with #47 interpolation should work natively for non-float64 matrixes, so this matrix method shouldn't be needed anymore.

[zsunberg]

This was fixed as part of #47 I believe