-
-
Notifications
You must be signed in to change notification settings - Fork 27.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CircuitPython #1327
Add CircuitPython #1327
Conversation
Request to add the Adafruit Industries curated awesome list devoted to CircuitPython, a microcontroller based version of Python, to the Python category. The Adafruit CircuitPython awesome list is at https://github.com/adafruit/awesome-circuitpython [https://github.com/adafruit/awesome-circuitpython] [Request to add the Adafruit Industries curated awesome list devoted to CircuitPython, a microcontroller based version of Python, to the Python category.] We have read the guidelines multiple times and have tried to ensure every single item is covered.
Is there any reason you opened this and closed #1326 instead of responding to the feedback? |
Yes, in the first submission a month ago, I did not receive feedback. I looked over your guidelines about git and I do not have a command line version running at this time, so I took the route proposed in #7 along with prior experience to make the changes. I apologize if this was not the best course of action. |
@legodude17 - I've tried rather hard to abide by the program requirements and I apologize if my git-foo isn't strong. Is everything in order? I'd like to ensure people know about our list via yours. Thank you. |
Joshua @legodude17 - we're coming up tomorrow on the filming of Ask an Engineer and my supervisor has asked about our posting. I told him I would ask the moderators if our submission met all criteria and would be posted in time for the broadcast. I sincerely hope our submission is correct and we can have our list join the others. I apologize if any of my actions have caused consternation in the submission process. Thank you for your consideration. @TheKitty |
@legodude17 - please? |
@TheKitty AFAICT it fulfills the requirements, but I do not have push access and am not an official maintainer. |
Ok, who would I ask politely to consider a merge? |
That would be @sindresorhus, but as he said in #1323 (comment), he is burnt out on this project right now. |
@sindresorhus - this one passes and is ready. Thanks for your hard work, Mike |
Per latest, point to readme in links
@sindresorhus - this one passes the new readme requirement and is ready. Thanks for your hard work, Mike |
My boss asked me why I haven't got the list on after 5 weeks. I didn't have an answer. :( |
I've done a PR with some improvements: adafruit/awesome-circuitpython#2 |
Adafruit really appreciates @sindresorhus improvements posted to https://github.com/adafruit/awesome-circuitpython - the PR was merges this morning. Cheers! |
Per new guidelines, Adafruit has reviewed the following PRs: @sindresorhus - is that sufficient? Thank you. PRs I made: |
Yup. All good :) |
awesome! 😎 |
Request to add the Adafruit Industries curated awesome list devoted to CircuitPython, a microcontroller based version of Python, to the Python category. The Adafruit CircuitPython awesome list is at https://github.com/adafruit/awesome-circuitpython
[https://github.com/adafruit/awesome-circuitpython]
[Request to add the Adafruit Industries curated awesome list devoted to CircuitPython, a microcontroller based version of Python, to the Python category.]
We have read the guidelines multiple times and have tried to ensure every single item is covered.
[https://github.com/adafruit/awesome-circuitpython]
[Request to add the Adafruit Industries curated awesome list devoted to CircuitPython, a microcontroller based version of Python, to the Python category.]
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
For example,
Add Name of List
, notUpdate readme.md
orAdd awesome list
.Example:
- [Fish](…) - User-friendly shell.
, not- [Fish](…) - Resources for Fish.
.Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.contributing.md
. Casing is up to you.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Go to the top and read it again.