Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CircuitPython #1327

Merged
merged 3 commits into from
Aug 3, 2018
Merged

Add CircuitPython #1327

merged 3 commits into from
Aug 3, 2018

Conversation

TheKitty
Copy link
Contributor

@TheKitty TheKitty commented Jun 6, 2018

Request to add the Adafruit Industries curated awesome list devoted to CircuitPython, a microcontroller based version of Python, to the Python category. The Adafruit CircuitPython awesome list is at https://github.com/adafruit/awesome-circuitpython
[https://github.com/adafruit/awesome-circuitpython]
[Request to add the Adafruit Industries curated awesome list devoted to CircuitPython, a microcontroller based version of Python, to the Python category.]

We have read the guidelines multiple times and have tried to ensure every single item is covered.

[https://github.com/adafruit/awesome-circuitpython]

[Request to add the Adafruit Industries curated awesome list devoted to CircuitPython, a microcontroller based version of Python, to the Python category.]

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

Requirements for your pull request

  • I have read and understood the contribution guidelines and the instructions for creating a list.
  • This pull request has a descriptive title.
    For example, Add Name of List, not Update readme.md or Add awesome list.
  • The entry in the Awesome list should:
    • Include a short description about the project/theme of the list. It should not describe the list itself.
      Example: - [Fish](…) - User-friendly shell., not - [Fish](…) - Resources for Fish..
    • Be added at the bottom of the appropriate category.
  • The list I'm submitting complies with these requirements:

Requirements for your Awesome list

  • Has been around for at least 30 days.
    That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
  • It's the result of hard work and the best I could possibly produce.
  • Non-generated Markdown file in a GitHub repo.
  • Includes a succinct description of the project/theme at the top of the readme. (Example)
  • The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
  • Not a duplicate.
  • Only has awesome items. Awesome lists are curations of the best, not everything.
  • Includes a project logo/illustration whenever possible.
    • Either fullwidth or placed at the top-right of the readme. (Example)
    • The image should link to the project website or any relevant website.
    • The image should be high-DPI. Set it to maximum half the width of the original image.
  • Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
  • Includes the Awesome badge.
    • Should be placed on the right side of the readme heading.
    • Should link back to this list.
  • Has a Table of Contents section.
    • Should be named Contents, not Table of Contents.
    • Should be the first section in the list.
    • Should only have one level of sub-lists, preferably none.
  • Has an appropriate license.
    • That means something like CC0, not a code licence like MIT, BSD, Apache, etc.
    • WTFPL and Unlicense are not acceptable licenses.
    • If you use a license badge, it should be SVG, not PNG.
  • Has contribution guidelines.
    • The file should be named contributing.md. Casing is up to you.
  • Has consistent formatting and proper spelling/grammar.
    • The link and description are separated by a dash.
      Example: - [AVA](…) - JavaScript test runner.
    • The description starts with an uppercase character and ends with a period.
    • Consistent and correct naming. For example, Node.js, not NodeJS or node.js.
  • Doesn't include a Travis badge.
    You can still use Travis for list linting, but the badge has no value in the readme.

Go to the top and read it again.

Request to add the Adafruit Industries curated awesome list devoted to CircuitPython, a microcontroller based version of Python, to the Python category. The Adafruit CircuitPython awesome list is at https://github.com/adafruit/awesome-circuitpython
[https://github.com/adafruit/awesome-circuitpython]
[Request to add the Adafruit Industries curated awesome list devoted to CircuitPython, a microcontroller based version of Python, to the Python category.]

We have read the guidelines multiple times and have tried to ensure every single item is covered.
@legodude17
Copy link

legodude17 commented Jun 6, 2018

Is there any reason you opened this and closed #1326 instead of responding to the feedback?

@TheKitty
Copy link
Contributor Author

TheKitty commented Jun 7, 2018

Yes, in the first submission a month ago, I did not receive feedback. I looked over your guidelines about git and I do not have a command line version running at this time, so I took the route proposed in #7 along with prior experience to make the changes. I apologize if this was not the best course of action.

@TheKitty
Copy link
Contributor Author

TheKitty commented Jun 8, 2018

@legodude17 - I've tried rather hard to abide by the program requirements and I apologize if my git-foo isn't strong. Is everything in order? I'd like to ensure people know about our list via yours. Thank you.

@TheKitty
Copy link
Contributor Author

Joshua @legodude17 - we're coming up tomorrow on the filming of Ask an Engineer and my supervisor has asked about our posting. I told him I would ask the moderators if our submission met all criteria and would be posted in time for the broadcast. I sincerely hope our submission is correct and we can have our list join the others. I apologize if any of my actions have caused consternation in the submission process. Thank you for your consideration. @TheKitty

@TheKitty
Copy link
Contributor Author

@legodude17 - please?

@legodude17
Copy link

@TheKitty AFAICT it fulfills the requirements, but I do not have push access and am not an official maintainer.

@TheKitty
Copy link
Contributor Author

Ok, who would I ask politely to consider a merge?

@legodude17
Copy link

That would be @sindresorhus, but as he said in #1323 (comment), he is burnt out on this project right now.

@TheKitty
Copy link
Contributor Author

@sindresorhus - this one passes and is ready. Thanks for your hard work, Mike

@TheKitty
Copy link
Contributor Author

TheKitty commented Jul 5, 2018

@sindresorhus - this one passes the new readme requirement and is ready. Thanks for your hard work, Mike

@TheKitty
Copy link
Contributor Author

My boss asked me why I haven't got the list on after 5 weeks. I didn't have an answer. :(

@sindresorhus sindresorhus changed the title Add CircuitPython to the Python section Add CircuitPython Jul 28, 2018
@sindresorhus
Copy link
Owner

@TheKitty You can send your boss a link to #1363. I'm only one person. I have 100+ PRs to go through. Many of which requires a lot of work.

@sindresorhus
Copy link
Owner

I've done a PR with some improvements: adafruit/awesome-circuitpython#2

@TheKitty
Copy link
Contributor Author

Adafruit really appreciates @sindresorhus improvements posted to https://github.com/adafruit/awesome-circuitpython - the PR was merges this morning. Cheers!

@TheKitty
Copy link
Contributor Author

TheKitty commented Aug 1, 2018

Per new guidelines, Adafruit has reviewed the following PRs:
#1160
and
#1127
and provided substantive comments as to getting them to meet the guidelines.

@sindresorhus - is that sufficient? Thank you.

PRs I made:
TheKitty/awesome-microbit#1
TheKitty/awesome-jupyter#1

@sindresorhus sindresorhus merged commit 31c1ff0 into sindresorhus:master Aug 3, 2018
@sindresorhus
Copy link
Owner

Yup. All good :)

@sindresorhus
Copy link
Owner

Tweet: https://twitter.com/awesome__re/status/1025240714718797824

@ladyada
Copy link

ladyada commented Aug 3, 2018

awesome! 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants