Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable geonames interlinking for cities #1

Closed
rtroncy opened this issue Mar 11, 2019 · 4 comments
Closed

Disable geonames interlinking for cities #1

rtroncy opened this issue Mar 11, 2019 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@rtroncy
Copy link
Contributor

rtroncy commented Mar 11, 2019

We attempted to use https://github.com/DOREMUS-ANR/string2vocabulary/ to match city and town names with Geonames URIs. However, the simple fuzzy matching strings are not efficient enough and this leads to a lot of linking mistakes, see also this issue.

Meanwhile, I recommend to disable the usage of string2vocabulary for city names in the converter.

@rtroncy rtroncy added the bug Something isn't working label Mar 11, 2019
@pasqLisena
Copy link
Contributor

Geonames matching is not managed by string2vocabulary, but by the official Geonames package.

What it is possible to try is to better setting the language or the country. (here the unique entry point for SILKNOW)

Instead, if the errors are few, it is possible to manually fix the mapping table.
This map is automatically generated and updated for the new values. For values already in the map, it acts as a cache.

@pasqLisena
Copy link
Contributor

FYI, I corrected the id for Saint Etienne, so that it will correctly link to the right city in next conversion

@rtroncy
Copy link
Contributor Author

rtroncy commented Apr 2, 2019

This has just amounted to add the line 281 of the mapping table?

If so, we should just close this issue

@pasqLisena
Copy link
Contributor

Yes, exactly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants