Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Allow continuation of stopped museval run #9

Open
StefanUhlich-sony opened this issue Apr 13, 2018 · 2 comments
Open

[FEATURE] Allow continuation of stopped museval run #9

StefanUhlich-sony opened this issue Apr 13, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@StefanUhlich-sony
Copy link

It would be great to have a continued_run=True keyword which can be used to continue a previous museval run, which was stopped before processing all songs (e.g., due to out-of-memory):

museval.eval_mus_dir(
    dataset=mus,  # instance of musdb
    estimates_dir=...,  # path to estimate folder
    output_dir=...,  # set a folder to write eval json files
    subsets="Test",
    parallel=True,
    is_wav=False,
    continued_run=True
)

museval should check whether the JSON folder already exists and - if there is already a JSON file - skip this song.

@faroit faroit added the enhancement New feature or request label Apr 13, 2018
@faroit
Copy link
Member

faroit commented Apr 13, 2018

maybe a overwrite flag would be simpler to understand, so that when overwrite=False, existing tracks are just skipped.

Also, we know that v4 needs way more memory than v3, so we might be better off fixing that as by introducing some memmap for the huge trackwise FFTs...

@faroit faroit self-assigned this Apr 13, 2018
@StefanUhlich-sony
Copy link
Author

overwrite looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants