[chore] Remove configuration for disabling opencensus.resourcetype #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests fail because we need to update the collector to 0.87.0 to remove this attribute. |
dmitryax
force-pushed
the
remove-opencensus.resourcetype-from-config
branch
from
ce78768
to
9033490
Compare
dmitryax
changed the title
You're right. I confused the version. Turning it to draft until 0.87.0 is released |
|
This should be merged along with the 0.87.0 release or after 0.87.0 image adoption and before the release. Otherwise, there will be some deprecation messages thrown |
The resource attribute was disabled upstream in 0.86.0 and will be removed in the next version. This change has no effect on the end users, so no need to mention in the changelog
dmitryax
force-pushed
the
remove-opencensus.resourcetype-from-config
branch
from
9033490
to
698b63d
Compare
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
@atoulme, rebased. PTAL |
|
I have read the CLA Document and I hereby sign the CLA |
srv-gh-o11y-gdi-cla
added a commit
to splunk/cla-agreement
that referenced
this pull request
Nov 1, 2023
jinja2
approved these changes
Nov 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resource attribute was disabled upstream in 0.87.0 and will be removed in the next version.
This change has no effect on the end users, so no need to mention in the changelog