Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Kubernetes v1.31.0 #1444

Closed
wants to merge 1 commit into from

Conversation

jvoravong
Copy link
Contributor

@jvoravong jvoravong commented Sep 9, 2024

Description:

  • Add support for Kubernetes v1.31.x

@jvoravong
Copy link
Contributor Author

jvoravong commented Sep 9, 2024

Initial Test Failures only for Kubernetes 1.31.0:

=== RUN   Test_Functions/agent_logs/test_journald_sourcetypes_are_set
    functional_test.go:931: 
        	Error Trace:	/home/runner/work/splunk-otel-collector-chart/splunk-otel-collector-chart/functional_tests/functional_test.go:931
        	Error:      	[]string(nil) does not contain "kube:journald:containerd.service"
        	Test:       	Test_Functions/agent_logs/test_journald_sourcetypes_are_set
    functional_test.go:932: 
        	Error Trace:	/home/runner/work/splunk-otel-collector-chart/splunk-otel-collector-chart/functional_tests/functional_test.go:932
        	Error:      	[]string(nil) does not contain "kube:journald:kubelet.service"
        	Test:       	Test_Functions/agent_logs/test_journald_sourcetypes_are_set
=== RUN   Test_Histograms
    histogram_test.go:113: creating 7 resource(s)
=== RUN   Test_Histograms/histogram_metrics_captured
    histogram_test.go:167: 
        	Error Trace:	/home/runner/work/splunk-otel-collector-chart/splunk-otel-collector-chart/functional_tests/histogram_test.go:167
        	Error:      	Received unexpected error:
        	            	open testdata_histogram/expected/v1.31/scheduler_metrics.yaml: no such file or directory
        	Test:       	Test_Histograms/histogram_metrics_captured

@atoulme
Copy link
Contributor

atoulme commented Sep 27, 2024

The first one is due to journald no longer present in the kind node image as of 1.30. We already skip tests for 1.30. See

if strings.HasPrefix(os.Getenv("K8S_VERSION"), "v1.30") {

Second one requires a run collecting expected files and adding them to this PR.

@atoulme
Copy link
Contributor

atoulme commented Oct 1, 2024

Closing this PR and reopening with a branch in this repository with #1483

@atoulme atoulme closed this Oct 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants