Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font size should be adjustable #864

Closed
1 task done
bungabunga opened this issue Aug 5, 2016 · 18 comments
Closed
1 task done

Font size should be adjustable #864

bungabunga opened this issue Aug 5, 2016 · 18 comments

Comments

@bungabunga
Copy link

  • I have searched open and closed issues for duplicates

Bug description

I don't have an optimal vision anymore and can't see the text in Signal Desktop well. My display is 1920x1080 on a 13" laptop and everywhere else I can somehow zoom-in/out but on Signal Desktop seems there's nothing i could do. I am really struggling to read/write here.

I've found a closed bug #465 about this topic but it's the same even after upgrade. I'm on the latest version.

Expected result: Font sizes should be adjustable with ctrl+scroll or a dedicated button in menu.

Platform info

Operating System: Ubuntu 16.04
Browser: Chromium

@bungabunga
Copy link
Author

bungabunga commented Sep 2, 2016

@liliakai hey, although this feature is already inplemented by b330b80, it seems it doesn't work for me. there's no effect doing crtl+scroll here.

Chromium 51.0.2704.79
Ubuntu 16.04 (64-bit)
Signal Desktop 0.21.0

@2-4601
Copy link
Contributor

2-4601 commented Sep 2, 2016

Can confirm. Same platform as @bungabunga

@Trolldemorted
Copy link
Contributor

Does not work on Windows 10 as well.
I do not know why, but the mousewheel event is not thrown.

@aurelg
Copy link

aurelg commented Sep 11, 2016

It's not working here either:

Chromium 53.0.2785.89-1~deb8u1
Debian Jessie (64-bits)
Signal Desktop pulled today from github (last commit: 6a4b720)

@2-4601
Copy link
Contributor

2-4601 commented Sep 30, 2016

@liliakai Could you please reopen this?

@ghost
Copy link

ghost commented Oct 4, 2016

I've made some changes: use the CTRL+ "+"/"-" instead the mouse wheel which was a bit weird choice if using the keyboard. First you need to focus the text area where you input the message and then you can change the font size. Keep in mind I've only implemented keycodes 187 for + and 189 for -, keycodes for numkeys are missing, because at the moment I don't have access at a full keyboard.
Maximus size is set to 22 now because bigger fonts went outside the message text area.

@ghost ghost mentioned this issue Oct 4, 2016
9 tasks
@ghost
Copy link

ghost commented Oct 5, 2016

Now the CTRL+ "+"/"-" can be called from the entire window. I've added the 'keydown' event listener to the document element in order to make it working. Added also keycodes for numpad + and -.

@Trolldemorted
Copy link
Contributor

did you try making the mousewheel event work?

since liliakai pushed a commit using it i assume it worked someday.

@ghost
Copy link

ghost commented Oct 5, 2016

I tried but it wasn't working. With the last commit I just added the tabindex=1 attribute to the inbox div and captured the keydown event. In this way we can still use the FontSizeView. If you don't add the tabindex attribute, keydown is detected only in the input fields.

@2-4601
Copy link
Contributor

2-4601 commented Oct 13, 2016

Also would be cool if the zoom level would persist after closing the app.

In other words

  1. Open Signal Desktop
  2. CTRL +, CTRL +, CTRL +
  3. Quit Signal Desktop
  4. Open Signal Desktop
  5. Zoom level has been reset

I would expect the level to be at CTRL +, CTRL +, CTRL +

Bonus candy: add CTRL 0 to reset the zoom

@ghost
Copy link

ghost commented Oct 16, 2016

Fixed with the latest commit

https://github.com/ping133/Signal-Desktop/tree/bug864

@lokesh-krishna
Copy link

Does the latest update have this commit merged? My zoom level is definitely reset each time I close and then open the app.

Platform: Linux Mint 18
Browser: Chromium

@lokesh-krishna
Copy link

Okay, I am on 0.26.0 and I am still unable to make my zoom setting stick after closing and opening the app. What is it that I am doing wrong?

@Robbepop
Copy link

I am using a QHD laptop with 14'' and even though my vision is pretty good I can barely read anything. The fonts are so small that it hurts my eyes reading. Even if you do not want to implement font size scaling a better (more adjusted) default font size could already do a lot.

@scottnonnenberg-signal
Copy link
Contributor

@Robbepop Seems like you need an OS-level zoom, not one specific to each app. Is it that Signal Desktop isn't honoring your system-level zoom settings?

@EvanHahn-Signal
Copy link
Contributor

You can scale the font with Ctrl-Plus and Ctrl-Minus (or Cmd-Plus and Cmd-Minus on macOS). Given the fact that I think this is solved and the fact that this issue has been quiet for almost a year, I'm going to close, but let me know if that's wrong and I'll reopen.

@githubuser6000
Copy link

Please reconsider. This is not a feature request. This makes the app so clunky to use. Either the UI is too big and unbelievably fat with padding that can fit whole continents around each element and the text is barely sufficient, or the UI scale is correct with the rest of the system but the font is a single pixel wide.

Some exaggeration and sarcasm at play, but the issue is there nonetheless. Why is signal yet and yet again ignoring such basic requests - font adjustment, single backup format across 3 platforms, opt-in to sync messages with a new linked device. Signal features have only been reactive over the past years, almost as if it's scared of losing market share to whatsapp and the like.

@xerces8
Copy link

xerces8 commented Oct 1, 2024

I have Windows 11 and font resizing is not working at all. I tried:

ctrl+mousewheel
menu View / Zoom In
ctrl +/- (both main keyboard and numpad)
changing it in the Preferences dialog (Appearance / Zoom level)

Also the default text size is way too small (and blurry).

EDIT: it seems all those actually work, but they affect only the preferences dialog, not the main app window (where the chats are).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests